Following a criminal indictment in New York, Donald Trump has become the first president, former or sitting, to face criminal.